[asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

Kevin Harwell reviewboard at asterisk.org
Tue Jul 15 14:55:47 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3797/#review12666
-----------------------------------------------------------



/trunk/res/res_pjsip/pjsip_options.c
<https://reviewboard.asterisk.org/r/3797/#comment22928>

    The formatter should also be unregistered.


A mention here just in case - I believe there is a testsuite test for the PJSIPShowEndpoint command.  It too should be updated to account for these changes (if you haven't already done that).

- Kevin Harwell


On July 15, 2014, 2:11 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3797/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 2:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds additional contact-specific output to PJSIPShowEndpoint output. For each contact bound to an AOR, we print the AOR name, the contact URI, whether the contact is reachable (or "Untracked" if not qualifying), and the roundtrip time for qualification attempts.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip/pjsip_options.c 418633 
> 
> Diff: https://reviewboard.asterisk.org/r/3797/diff/
> 
> 
> Testing
> -------
> 
> I have created both tracked and untracked contacts and ensured that the output looked correct for each.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140715/01befa34/attachment-0001.html>


More information about the asterisk-dev mailing list