[asterisk-dev] [Code Review] 3791: media_formats: chan_sip - Fix 3 bugs related to direct media

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3791/#review12663
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On July 15, 2014, 10:51 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3791/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 10:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This fixes three bugs caught by the direct media tests in the Test Suite:
> (1) When adding codecs to an outgoing SDP, we failed to add the added format to the alreadysent cap structure for peer codecs. This could result in duplicate codecs getting added to the SDP.
> (2) Another path that associates a dialog pvt structure with a peer failed to remove the capabilities on the dialog pvt before copying over the peer's. This resulted in the 'general' section codecs getting sent in a 200 OK to an inbound INVITE, along with the peer's.
> (3) Direct media checks needs to make sure that things have actually changed in capabilities between checks; otherwise it will spam the far side with re-INVITE requests.
> 
> 
> Diffs
> -----
> 
>   ./team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418631 
> 
> Diff: https://reviewboard.asterisk.org/r/3791/diff/
> 
> 
> Testing
> -------
> 
> The sip_hold_direct_media test now passes
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140715/81bbc69e/attachment.html>