[asterisk-dev] [Code Review] 3792: media formats: Fix audio within res_fax module.

[Joshua Colp]

> On July 15, 2014, 4:24 p.m., Matt Jordan wrote:
> > /team/group/media_formats-reviewed-trunk/res/res_fax.c, lines 1508-1513
> > <https://reviewboard.asterisk.org/r/3792/diff/2/?file=63356#file63356line1508>
> >
> >     When would we want to feed a non-format frame (meaning, non-VOICE) into the fax stack?
> >     
> >     In particular, should we be checking that the frame is VOICE before feeding it to the smoother?

T.38 can get fed into the stack the same way, and in that case no smoother exists.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3792/#review12652
-----------------------------------------------------------


On July 15, 2014, 4:17 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3792/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 4:17 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The res_fax module does some sanity checks on the frames it receives to make sure they have both the expected frame type and subclass. In the media formats branch the subclass is no longer a union, meaning that all fields are compared. The res_fax module initialized the integer field to -1 but on audio frames this is actually 0, causing the comparison to fail despite the audio frame being expected. This change makes the check more specific, and does an actual format comparison (since the format pointer may be of the same format but a difference structure).
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/res/res_fax.c 418628 
> 
> Diff: https://reviewboard.asterisk.org/r/3792/diff/
> 
> 
> Testing
> -------
> 
> PJSIP fax tests now pass happily.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140715/dcb72fcc/attachment-0001.html>