[asterisk-dev] [Code Review] 3786: media formats: Fix direct media codecs in PJSIP.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3786/
-----------------------------------------------------------

(Updated July 14, 2014, 6:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 418614


Repository: Asterisk


Description
-------

When doing direct media the res_pjsip_sdp_rtp module negotiates using only the media type of the specific stream. There is a function present which removes formats of all other types. This incorrectly removes all formats by accidentally using AST_MEDIA_TYPE_UNKNOWN. The patch fixes this so it does not.


Diffs
-----

  /team/group/media_formats-reviewed-trunk/res/res_pjsip_sdp_rtp.c 418612 

Diff: https://reviewboard.asterisk.org/r/3786/diff/


Testing
-------

Setup a call with a direct media bridge and confirmed no errors on console and media going direct. Without this patch an error would come up complaining about no compatible codecs.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140714/1f4f7829/attachment.html>