[asterisk-dev] [Code Review] 3763: media formats: Fix appending of compatible formats

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3763/
-----------------------------------------------------------

(Updated July 14, 2014, 9:42 a.m.)


Review request for Asterisk Developers, Corey Farrell and Matt Jordan.


Changes
-------

Switch to using ast_format_cap_get_compatible since it is sufficient in these use cases.


Repository: Asterisk


Description
-------

When ast_format_cap_append was replaced with ast_format_cap_append_from_cap, the behavior of the original function was not preserved. This change introduces ast_format_cap_append_compatible_from_cap which reproduces the original behavior of ast_format_cap_append and alters the original users of ast_format_cap_append to use ast_format_cap_append_compatible_from_cap.

The primary difference in behavior is that ast_format_cap_append_from_cap appends unconditionally from the source format capability while ast_format_cap_append checks for compatibility with ast_format_cap_iscompatible.


Diffs (updated)
-----

  team/group/media_formats-reviewed-trunk/res/res_pjsip_session.c 418507 
  team/group/media_formats-reviewed-trunk/res/res_pjsip_sdp_rtp.c 418507 
  team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418507 
  team/group/media_formats-reviewed-trunk/addons/chan_ooh323.c 418507 

Diff: https://reviewboard.asterisk.org/r/3763/diff/


Testing
-------

Ensured that calling a channel via Dial() produced the same behavior as trunk.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140714/f4b0557a/attachment.html>