[asterisk-dev] [Code Review] 3776: PresenceState action: make sure ActionID is returned on response; deprecate duplicate Message key

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3776/#review12623
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On July 14, 2014, 1:17 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3776/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 1:17 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23985
>     https://issues.asterisk.org/jira/browse/ASTERISK-23985
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch addresses two problems with the response to the PresenceState action:
> 
> (1) It calls astman_start_ack such that the ActionID, if present, is sent back with the response
> (2) It deprecates the second Message key in the response (which contains the presence message). Responses often contain a key of "Message"; dual purposing this key is cumbersome for many AMI clients that use dictionaries or hash tables to store events/responses. This patch proposes that the response contain the presence message in a PresenceMessage field. When the next major version of AMI is made, the duplicate Message field should be removed.
> 
> Part (1) of this patch should be backported to 11/12.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/manager.c 418582 
>   /trunk/UPGRADE.txt 418582 
> 
> Diff: https://reviewboard.asterisk.org/r/3776/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140714/8ef4c178/attachment.html>