[asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3770/#review12618
-----------------------------------------------------------



/branches/12/rest-api/api-docs/recordings.json
<https://reviewboard.asterisk.org/r/3770/#comment22900>

    While I'm not marking this as an issue I do wonder if "energy_duration" is too specific and technical for users of this. Would "speaking_duration" be better?


Despite my question about the naming the code itself is good, if discussion indicates that energy_duration is fine then this can go in!

- Joshua Colp


On July 13, 2014, 10:21 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3770/
> -----------------------------------------------------------
> 
> (Updated July 13, 2014, 10:21 p.m.)
> 
> 
> Review request for Asterisk Developers and Samuel Galarneau.
> 
> 
> Bugs: ASTERISK-24037
>     https://issues.asterisk.org/jira/browse/ASTERISK-24037
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds two new fields to the LiveRecording model, duration and energy_duration. duration is the time, in seconds, of the entire recording as reported by the Asterisk core; energy_duration is the time, in seconds, of the recording minus any silence that was detected while recording took place.
> 
> This is particularly useful when you want to throw away short recordings or recordings that are all silence.
> 
> Example RecordingFinished event:
> 
> {
>  "application":"testsuite",
>  "type":"RecordingFinished",
>  "recording":{"state":"done",
>               "format":"wav",
>               "name":"superfly",
>               "duration":5,
>               "target_uri":"channel:1405289721.1",
>               "energy_duration":4
>              }
> }
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/recordings.json 418507 
>   /branches/12/res/res_stasis_recording.c 418507 
>   /branches/12/res/ari/ari_model_validators.c 418507 
>   /branches/12/res/ari/ari_model_validators.h 418507 
> 
> Diff: https://reviewboard.asterisk.org/r/3770/diff/
> 
> 
> Testing
> -------
> 
> Testsuite tests will still need to be written for this feature. This will review will be updated once a test has been written that verifies audio + silence + audio along with expected durations.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140714/12049887/attachment.html>