[asterisk-dev] [Code Review] 3774: translate.c: Reduce the number of codec refs in the log when the translation matrix is rebuilt.

Corey Farrell reviewboard at asterisk.org
Sun Jul 13 21:19:11 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3774/#review12615
-----------------------------------------------------------

Ship it!


Ship It!

- Corey Farrell


On July 13, 2014, 10:13 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3774/
> -----------------------------------------------------------
> 
> (Updated July 13, 2014, 10:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is no need to ref/unref codecs when the debug level is not high enough to output the debug message.  This substantially reduces the refs log for codecs.
> 
> NOTE: The change to logger.h should go in v12+ by itself as it complements VERBOSITY_ATLEAST().
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/main/translate.c 418567 
>   /team/group/media_formats-reviewed-trunk/include/asterisk/logger.h 418567 
> 
> Diff: https://reviewboard.asterisk.org/r/3774/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140714/7329e194/attachment-0001.html>


More information about the asterisk-dev mailing list