[asterisk-dev] [Code Review] 3749: chan_dahdi.c: Restore some sanity checks on frames that dahdi_write() cannot handle.

opticron reviewboard at asterisk.org
Sun Jul 13 11:58:01 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3749/#review12603
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On July 11, 2014, 3:22 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3749/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 3:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Restored some sanity checks in dahdi_write() that were removed earlier in the formats work.  I know I've seen the incompatible format message in v12.
> 
> * Use ao2_cleanup() on a global pointer in the __unload_module() routine for safety.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c 418394 
> 
> Diff: https://reviewboard.asterisk.org/r/3749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140713/c93d2185/attachment.html>


More information about the asterisk-dev mailing list