[asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12595
-----------------------------------------------------------


This is working for me, although I can't qualify that it's ready to ship.


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3759/#comment22884>

    After applying your patch, I'm getting
    
    chan_sip.c:6503: error: conflicting types for ‘sip_registry_destroy’
    chan_sip.c:1377: note: previous declaration of ‘sip_registry_destroy’ was here
    
    Chaging 1377 to match 6503 fixes it.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3759/#comment22885>

    Compiler complains about converting pointer to int here, changing to return 0; fixes it.


- Scott Griepentrog


On July 12, 2014, 6:38 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3759/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Upgrade all ASTOBJ objects in chan_sip to ao2.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 418438 
>   /trunk/channels/chan_sip.c 418438 
> 
> Diff: https://reviewboard.asterisk.org/r/3759/diff/
> 
> 
> Testing
> -------
> 
> Full testsuite run.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140713/1f84412a/attachment.html>