[asterisk-dev] [Code Review] 3756: refcounter.py: use delta's to track current reference count, treat **destroyed** as just another "-1", partially fix a race condition in astobj2

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3756/
-----------------------------------------------------------

(Updated July 12, 2014, 2:42 a.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Rename res to old_refcount


Repository: Asterisk


Description
-------

This incorporates the ideas from r3572, with an improvement.  REF_DEBUG is still effective when ao2_ref(obj, -1) is run on an object that is already destroyed.

In addition refcounter.py is updated to use delta's to track the current reference count.  This works around a race condition where **destroyed** could be printed before the unref from 2.


Diffs (updated)
-----

  /branches/1.8/main/astobj2.c 417500 
  /branches/1.8/contrib/scripts/refcounter.py 417486 

Diff: https://reviewboard.asterisk.org/r/3756/diff/


Testing
-------

Verified that all false reported leaks are no longer.

One thing I noticed, the updated refcounter.py took 40 seconds to process a file when the same file was processed in 30 seconds before the change.  


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140712/8a3e2ce1/attachment.html>