[asterisk-dev] [Code Review] 3751: media_formats: resolve double unref of fmt in sip_new, clear fr->mallocd when we're not freeing fr.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3751/#review12572
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On July 11, 2014, 5 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3751/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 5 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * chan_sip: sip_new unref's fmt twice.  The unref that remains is at 8186.
> The check for if (fmt) should no longer be needed due addition of ast_format_none.  This check was ineffective anyways since fmt was used past the if statement.
> 
> * frame.c: ensure fr->mallocd is cleared if we are not freeing fr.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/main/frame.c 418416 
>   /team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418416 
> 
> Diff: https://reviewboard.asterisk.org/r/3751/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140711/688b30b4/attachment-0001.html>