[asterisk-dev] [Code Review] 3748: translate.c: Fix ref leaks in ast_translator_best_choice().

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3748/#review12565
-----------------------------------------------------------



/team/group/media_formats-reviewed-trunk/main/translate.c
<https://reviewboard.asterisk.org/r/3748/#comment22856>

    If you did the audit, then remove the BUGBUG on commit


- Matt Jordan


On July 11, 2014, 3:15 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3748/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 3:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Fixed ref leaks of bestdst and joint_cap in ast_translator_best_choice().
> 
> * Added BUGBUG notes in format.c about objects allocted with locks that don't need them.
> 
> * Fixed a couple doxygen comments in format.h
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/main/translate.c 418394 
>   /team/group/media_formats-reviewed-trunk/main/format.c 418394 
>   /team/group/media_formats-reviewed-trunk/include/asterisk/format.h 418394 
> 
> Diff: https://reviewboard.asterisk.org/r/3748/diff/
> 
> 
> Testing
> -------
> 
> The ref leak no longer happens when I call into dialplan to playback tt-weasels from an ISDN phone.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140711/fb58b4a6/attachment-0001.html>