[asterisk-dev] [Code Review] 3746: media formats: Fix double unref on full cache

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3746/#review12564
-----------------------------------------------------------

Ship it!


Ship It!

- Corey Farrell


On July 11, 2014, 3:30 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3746/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 3:30 p.m.)
> 
> 
> Review request for Asterisk Developers, Corey Farrell and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If the frame cache on a thread is full, the format on a frame will be double-unreffed. This fixes the double-unref by making sure the first unref only occurs if the frame actually goes into the TLS frame cache.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/main/frame.c 418348 
> 
> Diff: https://reviewboard.asterisk.org/r/3746/diff/
> 
> 
> Testing
> -------
> 
> Moved on to the next crash.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140711/a564b06c/attachment-0001.html>