[asterisk-dev] [Code Review] 3743: astobj2: tweak ao2_replace to do nothing when it would be a NoOp

Matt Jordan reviewboard at asterisk.org
Fri Jul 11 15:53:38 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3743/#review12561
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 11, 2014, 3:50 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3743/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 3:50 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change causes ao2_replace to do nothing when src == dst.  The primary purpose of this is to avoid REF_DEBUG logging when we're not actually doing anything.
> 
> 
> Diffs
> -----
> 
>   /branches/12/include/asterisk/astobj2.h 418364 
> 
> Diff: https://reviewboard.asterisk.org/r/3743/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140711/23e7b71d/attachment.html>


More information about the asterisk-dev mailing list