[asterisk-dev] [Code Review] 3748: translate.c: Fix ref leaks in ast_translator_best_choice().

rmudgett reviewboard at asterisk.org
Fri Jul 11 15:15:55 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3748/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

* Fixed ref leaks of bestdst and joint_cap in ast_translator_best_choice().

* Added BUGBUG notes in format.c about objects allocted with locks that don't need them.

* Fixed a couple doxygen comments in format.h


Diffs
-----

  /team/group/media_formats-reviewed-trunk/main/translate.c 418394 
  /team/group/media_formats-reviewed-trunk/main/format.c 418394 
  /team/group/media_formats-reviewed-trunk/include/asterisk/format.h 418394 

Diff: https://reviewboard.asterisk.org/r/3748/diff/


Testing
-------

The ref leak no longer happens when I call into dialplan to playback tt-weasels from an ISDN phone.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140711/85ba42cb/attachment.html>


More information about the asterisk-dev mailing list