[asterisk-dev] [Code Review] 3742: media formats: Ensure that chan_pjsip sets its native formats properly

Matt Jordan reviewboard at asterisk.org
Thu Jul 10 21:16:51 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3742/#review12553
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 10, 2014, 5:11 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3742/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 5:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> During the media rework, setting of nativeformats for chan_pjsip channels was removed for inbound channels. This prevents chan_pjsip channels from dialing other channels due to having (nothing) as their native format capability. It's hard to transcode from (something) to (nothing). This tweak gives chan_pjsip channels back their native formats on creation.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/channels/chan_pjsip.c 418253 
> 
> Diff: https://reviewboard.asterisk.org/r/3742/diff/
> 
> 
> Testing
> -------
> 
> Made sure the incoming call could dial other channels and pass audio.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140711/5281ab8d/attachment.html>


More information about the asterisk-dev mailing list