[asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

[rmudgett]

> On July 10, 2014, 3:15 p.m., rmudgett wrote:
> > /team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c, lines 19548-19551
> > <https://reviewboard.asterisk.org/r/3740/diff/1/?file=62754#file62754line19548>
> >
> >     I wonder why __unload_module() isn't called instead since we've allocated a bunch of other stuff.
> 
> Matt Jordan wrote:
>     Mostly just because I wasn't sure if it was safe to do or not. If you think it's safe to call here, then I'll change it to that.

Its called earlier in the function for other error exits.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3740/#review12549
-----------------------------------------------------------


On July 10, 2014, 2:41 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3740/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 2:41 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> chan_dahdi was really kind of a bonus, my goal here was to make sure a clean start up + shutdown of format and frame stuff in the core without any modules loaded didn't leak memory. I think this is the last container not getting destroyed on shutdown.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/main/format.c 418348 
>   /team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c 418349 
> 
> Diff: https://reviewboard.asterisk.org/r/3740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140710/7db80bf8/attachment-0001.html>