[asterisk-dev] [Code Review] 3739: Remove ref bumps on a number of static frames

Matt Jordan reviewboard at asterisk.org
Thu Jul 10 13:33:13 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3739/
-----------------------------------------------------------

(Updated July 10, 2014, 1:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and Corey Farrell.


Changes
-------

Committed in revision 418349


Repository: Asterisk


Description
-------

A first pass on removing ao2_bumps on formats assigned to statically allocated frames. With this + opticron's previous patch, I could get a file played back to a Local channel without crashing.

Going to start looking for ref leaks with this patch now.


Diffs
-----

  /team/group/media_formats-reviewed-trunk/codecs/codec_resample.c 418348 
  /team/group/media_formats-reviewed-trunk/codecs/codec_dahdi.c 418348 
  /team/group/media_formats-reviewed-trunk/channels/chan_phone.c 418348 
  /team/group/media_formats-reviewed-trunk/channels/chan_misdn.c 418348 
  /team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c 418348 
  /team/group/media_formats-reviewed-trunk/channels/chan_alsa.c 418348 
  /team/group/media_formats-reviewed-trunk/apps/app_sms.c 418348 
  /team/group/media_formats-reviewed-trunk/apps/app_nbscat.c 418348 
  /team/group/media_formats-reviewed-trunk/apps/app_mp3.c 418348 
  /team/group/media_formats-reviewed-trunk/apps/app_milliwatt.c 418348 
  /team/group/media_formats-reviewed-trunk/apps/app_jack.c 418348 
  /team/group/media_formats-reviewed-trunk/apps/app_festival.c 418348 
  /team/group/media_formats-reviewed-trunk/addons/chan_mobile.c 418348 

Diff: https://reviewboard.asterisk.org/r/3739/diff/


Testing
-------


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140710/001caa13/attachment.html>


More information about the asterisk-dev mailing list