[asterisk-dev] [Code Review] 3737: Media Formats: Fix leak on translation path calculation

Corey Farrell reviewboard at asterisk.org
Thu Jul 10 12:29:46 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3737/#review12545
-----------------------------------------------------------

Ship it!


Ship It!

- Corey Farrell


On July 10, 2014, 12:56 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3737/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 12:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23960
>     https://issues.asterisk.org/jira/browse/ASTERISK-23960
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Ensure that inputs to ast_translator_best_choice are handled consistently so that references held in output variables are handled properly in all locations.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/main/translate.c 418346 
> 
> Diff: https://reviewboard.asterisk.org/r/3737/diff/
> 
> 
> Testing
> -------
> 
> Verified that repeated Playback()s in the dialplan no longer incremented the format's refcount.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140710/9bf155e9/attachment.html>


More information about the asterisk-dev mailing list