[asterisk-dev] [Code Review] 3729: Stasis: Allow prestart actions to be queued

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3729/#review12530
-----------------------------------------------------------



branches/12/res/stasis/command.h
<https://reviewboard.asterisk.org/r/3729/#comment22804>

    \pre Chan must be locked.



branches/12/res/stasis/command.h
<https://reviewboard.asterisk.org/r/3729/#comment22805>

    \pre Chan must be locked.



branches/12/res/stasis/command.c
<https://reviewboard.asterisk.org/r/3729/#comment22803>

    visine gets the red out



branches/12/res/stasis/command.c
<https://reviewboard.asterisk.org/r/3729/#comment22807>

    Depending upon how you want to use this function in general, you probably should return a ref to the container.



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/3729/#comment22806>

    Either chan must be locked before calling or you need to lock chan around calling command_prestart_get_container().
    
    Probably best to lock around command_prestart_get_container().



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/3729/#comment22802>

    Please use the name iter instead of the single char name i.


- rmudgett


On July 8, 2014, 8:24 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3729/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 8:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23941
>     https://issues.asterisk.org/jira/browse/ASTERISK-23941
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This allows commands to be queued in a channel datastore to be executed upon a channel entering Stasis(). This functionality is only available from components of res_stasis.so. This functionality is required to get a redirected channel back into the bridge for which it was destined due to the attended transfer.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/stasis/control.c 418213 
>   branches/12/res/stasis/control.h 418213 
>   branches/12/res/stasis/command.c 418213 
>   branches/12/res/stasis/command.h 418213 
>   branches/12/res/res_stasis.c 418213 
> 
> Diff: https://reviewboard.asterisk.org/r/3729/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of the complete solution to ASTERISK-23941.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140709/26b84ce7/attachment.html>