[asterisk-dev] [Code Review] 3728: ARI: Add missing transfer information

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3728/#review12529
-----------------------------------------------------------



branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/3728/#comment22800>

    This should hold a reference to the channel.  As it is the local channel pointer is potentially a stale pointer.



branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/3728/#comment22799>

    ast_bridge_impart is taking the local_chan reference if successful.  The code following no longer has a valid reference to local_chan and should not be using it anymore.



branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/3728/#comment22801>

    This is a stale local channel pointer that should not be used as the code no longer has a reference to the channel.


- rmudgett


On July 8, 2014, 8:07 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3728/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 8:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23941
>     https://issues.asterisk.org/jira/browse/ASTERISK-23941
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds a new field to the ast_attended_transfer_type() and a new subtype AST_ATTENDED_TRANSFER_DEST_LOCAL_APP to describe attended transfers where a local channel is used to connect a dialplan application to a bridge in cases where a single remote party can not be moved directly into the application. Previously, the local channel half being pushed into the bridge in place of a transferer leg was not conveyed in the message.
> 
> 
> Diffs
> -----
> 
>   branches/12/rest-api/api-docs/events.json 418213 
>   branches/12/res/ari/ari_model_validators.c 418213 
>   branches/12/res/ari/ari_model_validators.h 418213 
>   branches/12/main/stasis_bridges.c 418213 
>   branches/12/main/cel.c 418213 
>   branches/12/main/bridge.c 418213 
>   branches/12/include/asterisk/stasis_bridges.h 418213 
>   branches/12/apps/app_queue.c 418213 
> 
> Diff: https://reviewboard.asterisk.org/r/3728/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of the complete solution to ASTERISK-23941.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140709/6f8a8f0e/attachment-0001.html>