[asterisk-dev] [Code Review] 3727: Install dahdi span hook only if relevant

[Corey Farrell]

> On July 8, 2014, 2:52 p.m., Corey Farrell wrote:
> > I just checked, the Makefile optionally includes makeopts.  It is only optional so the Makefile can print a nice message that you need to ./configure.  This file sets DAHDI_INCLUDE, checking that for non-blank in addition to the check for --prefix would make me very happy.  In general people aren't going to install the dahdi development package then choose to not build chan_dahdi.
> 
> Tzafrir Cohen wrote:
>     DAHDI_INCLUDE gets an empty value on my system (that builds chan_dahdi). I can't see any other way for the makefile to see the result of PBX_DAHDI from autoconf (except a direct sed from build_tools/menuselect-deps).

Sorry as I said I don't have dahdi on my test system so I couldn't see that.  What about adding a new variable in makeopts.in set to @PBX_DAHDI@?


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3727/#review12513
-----------------------------------------------------------


On July 8, 2014, 11:37 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3727/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 11:37 a.m.)
> 
> 
> Review request for Asterisk Developers and Corey Farrell.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Commit r417863 added support for installing a hook script for dahdi under /usr/share/dahdi/span_config.d . This, however, broke support for users setting --prefix=$HOME:
> 
> /usr/bin/install -c -d //usr/share/dahdi/span_config.d
> /usr/bin/install: cannot create directory ‘//usr/share/dahdi’: Permission denied
> 
> Suggested fix: only install the hook prefix is /usr.
> 
> Note: installing only if chan_dahdi was enabled is not easy as menuselect.makeopts is not included into the main Makefile.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 418065 
> 
> Diff: https://reviewboard.asterisk.org/r/3727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140708/834a9324/attachment.html>