[asterisk-dev] [Code Review] 3720: ARI: Make mixing bridges propagate linkedids and accountcodes.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3720/#review12512
-----------------------------------------------------------

Ship it!


Made https://issues.asterisk.org/jira/browse/ASTERISK-24003 for tests... :-)

- Matt Jordan


On July 7, 2014, 5:06 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3720/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 5:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23852
>     https://issues.asterisk.org/jira/browse/ASTERISK-23852
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Create a Stasis bridge sub-class to propagate linkedids and
> accountcodes.
> 
> * Fixed the basic bridge sub-class to update peeraccount codes when the
> number of channels in the bridge drops back down to two parties.
> 
> * Refactored ast_bridge_channel_update_accountcodes() to handle channels
> joining/leaving the bridge.
> 
> * Fixed the basic bridge sub-class to not call the base bridge class pull
> method twice.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/stasis/stasis_bridge.c PRE-CREATION 
>   /branches/12/res/stasis/stasis_bridge.h PRE-CREATION 
>   /branches/12/res/res_stasis.c 418155 
>   /branches/12/main/bridge_channel.c 418155 
>   /branches/12/main/bridge_basic.c 418155 
>   /branches/12/include/asterisk/bridge_channel.h 418155 
> 
> Diff: https://reviewboard.asterisk.org/r/3720/diff/
> 
> 
> Testing
> -------
> 
> With the patch the linkedids are propagated like the basic bridge sub-class.
> Accountcodes will be propagated too when peeraccount support is truly implemented on trunk.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140708/9890fc46/attachment-0001.html>