[asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3591/#review12504
-----------------------------------------------------------

Ship it!


A few cosmetic issues below.

Could the committer fix these *and* add an entry to the CHANGES file?


/trunk/cdr/cdr_pgsql.c
<https://reviewboard.asterisk.org/r/3591/#comment22766>

    Missing space after comma.



/trunk/cel/cel_pgsql.c
<https://reviewboard.asterisk.org/r/3591/#comment22767>

    Missing space after comma.



/trunk/configs/cdr_pgsql.conf.sample
<https://reviewboard.asterisk.org/r/3591/#comment22768>

    s/Whitespaces/Whitespace/



/trunk/configs/cel_pgsql.conf.sample
<https://reviewboard.asterisk.org/r/3591/#comment22769>

    s/Whitespaces/Whitespace/



/trunk/configs/res_pgsql.conf.sample
<https://reviewboard.asterisk.org/r/3591/#comment22770>

    s/Whitespaces/Whitespace/



/trunk/res/res_config_pgsql.c
<https://reviewboard.asterisk.org/r/3591/#comment22771>

    Missing space after comma.


- wdoekes


On July 7, 2014, 10:10 a.m., doome wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3591/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 10:10 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23737
>     https://issues.asterisk.org/jira/browse/ASTERISK-23737
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> See https://issues.asterisk.org/jira/browse/ASTERISK-23737
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_config_pgsql.c 415300 
>   /trunk/configs/res_pgsql.conf.sample 415300 
>   /trunk/configs/cel_pgsql.conf.sample 415300 
>   /trunk/configs/cdr_pgsql.conf.sample 415300 
>   /trunk/cel/cel_pgsql.c 415300 
>   /trunk/cdr/cdr_pgsql.c 415300 
> 
> Diff: https://reviewboard.asterisk.org/r/3591/diff/
> 
> 
> Testing
> -------
> 
> Used asterisk with the config paramterer pgdbappname and dbappname in cdr_pgsql.conf and res_config_pgsql.conf respectively, enabled and disabled. Worked as expected.
> 
> 
> Thanks,
> 
> doome
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140707/00bb159b/attachment-0001.html>