[asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3705/
-----------------------------------------------------------

(Updated July 7, 2014, 2:39 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-21443
    https://issues.asterisk.org/jira/browse/ASTERISK-21443


Repository: Asterisk


Description
-------

This change does the following:

1. Provides the underlying subscription to body generators for extension state by placing it in the data structure.
2. Makes the ast_sip_presence_xml_create_node function optionally add the created node to a parent node.
3. Adds dialog as a supported event to res_pjsip_exten_state.
4. Adds a res_pjsip_dialog_info_body_generator module for generating the dialog-info+xml body for NOTIFY messages.


Diffs (updated)
-----

  /branches/12/res/res_pjsip_exten_state.c 418111 
  /branches/12/res/res_pjsip_dialog_info_body_generator.c PRE-CREATION 
  /branches/12/res/res_pjsip/presence_xml.c 418111 
  /branches/12/include/asterisk/res_pjsip_presence_xml.h 418111 
  /branches/12/include/asterisk/res_pjsip_body_generator_types.h 418111 

Diff: https://reviewboard.asterisk.org/r/3705/diff/


Testing
-------

Used a Grandstream phone to subscribe and watched NOTIFY messages go to it as I did things.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140707/00f96fbd/attachment.html>