[asterisk-dev] [Code Review] 3713: media_formats: Correct issues caused by r3689 (the great rename)

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3713/
-----------------------------------------------------------

(Updated July 5, 2014, 11:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 418065


Repository: Asterisk


Description
-------

I missed a couple issues on r3689:
* chan_mgcp: buf unused variable prevents devmode build
* chan_skinny / chan_unistim: tech.capabilities double ao2_cleanup
* format_cap: ao2_ref(framed, +1) was mistakenly removed, causing many fracks

In the case of format_cap, I didn't notice that it was being added to a cap->formats and caps->preference_order.


Diffs
-----

  /team/group/media_formats-reviewed-trunk/main/format_cap.c 418064 
  /team/group/media_formats-reviewed-trunk/channels/chan_unistim.c 418064 
  /team/group/media_formats-reviewed-trunk/channels/chan_skinny.c 418064 
  /team/group/media_formats-reviewed-trunk/channels/chan_mgcp.c 418064 

Diff: https://reviewboard.asterisk.org/r/3713/diff/


Testing
-------

Compile, run, shutdown gracefully with no fracks.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140705/aec95adf/attachment.html>