[asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

Joshua Colp reviewboard at asterisk.org
Thu Jul 3 11:47:18 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3709/#review12475
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On July 3, 2014, 4:36 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3709/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 4:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23905
>     https://issues.asterisk.org/jira/browse/ASTERISK-23905
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Review https://reviewboard.asterisk.org/r/3647/ introduced PFS in Asterisk that depends on the elliptic curve library support being present in OpenSSL. As it turns out, some versions of OpenSSL don't have this library - notably the version running on our build agents.
> 
> This patch fixes the build by providing a configure check for the specific library calls that the PFS patch relies on.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/tcptls.c 417876 
>   /trunk/include/asterisk/autoconfig.h.in 417876 
>   /trunk/configure.ac 417876 
>   /trunk/configure UNKNOWN 
> 
> Diff: https://reviewboard.asterisk.org/r/3709/diff/
> 
> 
> Testing
> -------
> 
> With ec.h present, Asterisk detects the header via the presence of the specified function and sets HAVE_OPENSSL_EC to 1.
> 
> Without ec.h present, Asterisk does not detect the file. HAVE_OPENSSL_EC is 0, and the build succeeds.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140703/f2219bcf/attachment.html>


More information about the asterisk-dev mailing list