[asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3690/
-----------------------------------------------------------

(Updated July 1, 2014, 11:13 a.m.)


Review request for Asterisk Developers and Corey Farrell.


Changes
-------

Some rework for a cleaner patch. No deduplication or further duplication necessary.


Repository: Asterisk


Description
-------

This corrects two issues with the extra field information in Asterisk 12+ in channel event logs.

It is possible to inject custom values into the dialstatus provided by ast_channel_dial_type() Stasis messages that fall outside the enumeration allowed for the DIALSTATUS channel variable. CEL now filters for the allowed values and ignores other values.

The "hangupsource" extra field key is always blank if the far end channel is a chan_pjsip channel. This is because the hangupsource is never set for the pjsip channel driver. This change sets the hangupsource whenever a hangup is queued for chan_pjsip channels.

This corrects an issue with the pjsip channel driver where the hangupcause information was not being set properly. This required that the hangup_sip2cause functionality be pulled out of chan_sip and chan_pjsip into main/causes.c so that it could also be utilized by res_pjsip_session.


Diffs (updated)
-----

  branches/12/tests/test_cel.c 417545 
  branches/12/res/res_pjsip_session.c 417545 
  branches/12/main/cel.c 417545 
  branches/12/channels/chan_pjsip.c 417545 

Diff: https://reviewboard.asterisk.org/r/3690/diff/


Testing
-------

Tested all three portions of the patch manually and the dial status portion using the included unit test.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140701/8054d04a/attachment.html>