[asterisk-dev] [Code Review] 3165: Testsuite res_pjsip_mwi: Subscribe fails when missing aor name

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3165/#review10737
-----------------------------------------------------------



asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/run-test
<https://reviewboard.asterisk.org/r/3165/#comment20233>

    Just to be 'good', go ahead and run pylint on this and correct the errors. In particular, some doc strings would be good.



asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/run-test
<https://reviewboard.asterisk.org/r/3165/#comment20232>

    In general, it's probably not a good idea to call a test class 'Test', if for no other reason than it's a bit generic. I'd call it MissingAoR, since that's the name of the test.


- Matt Jordan


On Jan. 28, 2014, 12:34 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3165/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 12:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23072
>     https://issues.asterisk.org/jira/browse/ASTERISK-23072
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test subscribing to all aors on an endpoint when the aor name is missing from the sip uri.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/pjsip/tests.yaml 4599 
>   asterisk/trunk/tests/channels/pjsip/subscribe/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/sipp/subscribe.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/pjsip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/modules.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3165/diff/
> 
> 
> Testing
> -------
> 
> Ran test and it passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140131/478a9bba/attachment.html>