[asterisk-dev] [Code Review] 3170: app_confbridge: MOH is not working for transferee after attended sip transfer

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3170/#review10735
-----------------------------------------------------------


Kevin, we're doing double work. Please check my branch https://origsvn.digium.com/svn/asterisk/team/oej/rana-moh-queue-transfer-1.8 and see if we have the same solution. I discussed this quite in detail with Matt at the time I did this. Cheers /O

- Olle E Johansson


On Jan. 30, 2014, 11:29 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3170/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 11:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-19499
>     https://issues.asterisk.org/jira/browse/ASTERISK-19499
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> For a user when 'music_on_hold_when_empty=yes' and after attempting to do a sip attended transfer into a confbridge the MOH for the transferee stops.  The problem that was occuring is that once the channel was masqueraded it was take off hold, which stops the music, and confbridge had no way of knowing that this occurred.  The solution was two fold: 1) "unhold" the transferee before being masqueraded and 2) add a fixup handler to confbridge so it can be notified that the channel was masqueraded and things need ...well fixing up (in this case turn MOH back on).
> 
> 
> Diffs
> -----
> 
>   branches/11/main/channel.c 406859 
>   branches/11/channels/chan_sip.c 406859 
>   branches/11/apps/app_confbridge.c 406859 
> 
> Diff: https://reviewboard.asterisk.org/r/3170/diff/
> 
> 
> Testing
> -------
> 
> With the appropriate configuration succesfully completed an attended transfer into a confbridge with music still playing.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140131/98b568f5/attachment.html>