[asterisk-dev] [Code Review] 3167: alembic: script modifications due to errors

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3167/#review10727
-----------------------------------------------------------



branches/12/UPGRADE.txt
<https://reviewboard.asterisk.org/r/3167/#comment20221>

    This needs a big UPGRADE note.
    
    Essentially, if you tried to run the install script for the extensions realtime table for MySQL in 12.0, it was broken. Which means there's no way you could have gotten it to work, but even still, that means that the upgrade management provided by alembic won't work properly, since we had to modify the base file.
    
    I'm not sure if there is another way around this, but there needs to be a mea culpa in the UPGRADE notes so people know what to expect. We should tell them what they have to do to upgrade their databases as a result.


- Matt Jordan


On Jan. 30, 2014, 11:51 a.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3167/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 11:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A couple of the scripts had errors that would not allow a full migration to take place.  The extensions table needed to make its 'id' column a primary key in order to work with mysql.  The other script ...add_endpoints... was missing tables that it was trying to add columns to.
> 
> Added the primary key on id for extensions and added the tables in for the missing pjsip configuration options. 
> 
> 
> Diffs
> -----
> 
>   branches/12/contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py 406846 
>   branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py 406846 
>   branches/12/UPGRADE.txt 406846 
> 
> Diff: https://reviewboard.asterisk.org/r/3167/diff/
> 
> 
> Testing
> -------
> 
> Ran the alembic scripts against postgres and mysql database servers to make sure everything was created correctly.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140130/89a9b735/attachment-0001.html>