[asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3168/
-----------------------------------------------------------

(Updated Jan. 30, 2014, 2:27 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address Joshua's comments.


Bugs: ASTERISK-23106
    https://issues.asterisk.org/jira/browse/ASTERISK-23106


Repository: Asterisk


Description
-------

In NAT scenarios where a call is placed to a Grandstream phone, res_pjsip will sometimes send the ACK to a 200 OK to the private address of the device behind the NAT instead of the address of the NAT device. This corrects that behavior by rewriting the address in the Contact header in the incoming 200 OK and the dialog's target address if necessary (since it has already been rewritten to the incorrect private address).


Diffs (updated)
-----

  branches/12/res/res_pjsip_nat.c 406916 

Diff: https://reviewboard.asterisk.org/r/3168/diff/


Testing
-------

Manual testing and a new testsuite test at https://reviewboard.asterisk.org/r/3169/


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140130/f6a499bc/attachment.html>