[asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3104/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 4:20 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added test for failed allocation in cli_print_identify_body.


Repository: Asterisk


Description
-------

Adds identify, transport and registration support to the CLI.
Creates 3 additional callbacks, one for an iterator, one for a comparator and one for a container.  This eliminates the link dependency from higher level modules to lower level ones.
Eliminates duplicate sorting.
Cleans up output formatting.
Pushes cli registration down to the implementing source file.
Adds several ast_sip_destroy_sorcery functions to complement existing ast_sip_sorcery_initialize functions.  The destroy functions unregister cli commands and cli formatters.


Diffs (updated)
-----

  branches/12/res/res_pjsip_outbound_registration.c 406802 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 406802 
  branches/12/res/res_pjsip/pjsip_options.c 406802 
  branches/12/res/res_pjsip/pjsip_configuration.c 406802 
  branches/12/res/res_pjsip/pjsip_cli.c 406802 
  branches/12/res/res_pjsip/location.c 406802 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 406802 
  branches/12/res/res_pjsip/config_transport.c 406802 
  branches/12/res/res_pjsip/config_global.c 406802 
  branches/12/res/res_pjsip/config_domain_aliases.c 406802 
  branches/12/res/res_pjsip/config_auth.c 406802 
  branches/12/include/asterisk/res_pjsip_cli.h 406802 
  branches/12/include/asterisk/res_pjsip.h 406802 

Diff: https://reviewboard.asterisk.org/r/3104/diff/


Testing
-------


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140128/c048da5c/attachment.html>