[asterisk-dev] DAHDI / indications: US tone as stutter on India, Mexico, and the Philippines

[Richard Mudgett]

On Mon, Jan 27, 2014 at 4:52 AM, Tzafrir Cohen <tzafrir.cohen at xorcom.com>wrote:

> On Sun, Jan 26, 2014 at 04:21:35PM -0600, Richard Mudgett wrote:
> > On Sun, Jan 26, 2014 at 7:44 AM, Tzafrir Cohen <tzafrir.cohen at xorcom.com
> >wrote:
> >
> > > Hi,
> > >
> > > A while ago we noticed while testing that if you set the tonezone of a
> > > DAHDI phone to Mexican ("mx"), a phone with a message waiting
> eventually
> > > gives a US dialtone after the stutter tone is over. This is because in
> > > zonedata.c:
> > >
> > >           .country = "mx",
> > > ...
> > >                         { DAHDI_TONE_DIALTONE, "425" },
> > > ...
> > >                         { DAHDI_TONE_STUTTER,
> > >
> "!350+440/100,!0/100,!350+440/100,!0/100,!350+440/100,!0/100,!350+440/100,!0/100,!350+440/100,!0/100,!350+440/100,!0/100,350+440"
> > > },
> > >
> > > As you can see, it ends with the tones 350+440, the same as the US
> > > dialtone. I suspect that this is copy&paste from the "us" definition.
> > >
> > > A quick look at the file shows that the India (in) and Philipines (ph)
> > > definitions have the same issue. It's the same in indications.conf.
>
> Likewise for Thailand (th)
>
> > >
> > > Asterisk's indications.conf gives [1] as a reference to some country's
> > > indications data. That file does not have information about voicemail
> > > indication tone for Mexico.
> > >
> > > Is this a problem or is this the expected behaviour? A quick search
> > > found no results.
> > >
> > > [1] http://www.itu.int/ITU-T/inr/forms/files/tones-0203.pdf
> > >
> >
> > Since the stutter tone is not defined by the standard but is a dialtone,
> I
> > think it should
> > stutter the same tones as the country specific dialtone.  At the very
> least
> > it should stop
> > stuttering and become a normal dialtone.
>
> I noticed that some countries don't have stutter tones. Should they be
> added in the same way? The us stutter tone ended with the country's dial
> tone?
>
> [es]
> stutter =
> !425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,425
>
> [fi]
> stutter =
> !425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,425
>
> [my]
> ; missing some other fields
> stutter =
> !425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,425
>
> [ve]
> stutter =
> !425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,!425/100,!0/100,425
>


Yes they should because chan_dahdi does not check if the tone exists or not
before
attempting to use it.

Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140127/a4ff0338/attachment.html>