[asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3145/#review10692
-----------------------------------------------------------



/asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py
<https://reviewboard.asterisk.org/r/3145/#comment20186>

    Seeing something like this is typically a red flag for me when reviewing a test. Rather than calling a_transfer 5 seconds later, opt to react to an AMI event (such as a NewExten event showing the channel executing the Wait application) so that you can guarantee the call from a to 1000 has been properly set up.
    
    In most cases, this is likely to result in a faster test execution. More importantly, though, is in those oddball cases where 5 seconds is not enough to guarantee the call is up, you'll wait the appropriate extra time before executing the transfer.



/asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py
<https://reviewboard.asterisk.org/r/3145/#comment20184>

    Reviewboard is showing a red blob here. I think it's because you've indented with 4 spaces and a tab instead of 8 spaces.



/asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3145/#comment20188>

    Both tests have an s extension, but they don't appear to be used for anything.



/asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3145/#comment20190>

    Consider using Echo instead of Wait here. That way, there's no risk of the call being hung up before the transfer can happen.



/asterisk/trunk/tests/rest_api/bridges/blind_transfer/blind_transfer.py
<https://reviewboard.asterisk.org/r/3145/#comment20185>

    Similar red blob here as the first one.



/asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3145/#comment20191>

    Same suggestion of using Echo here instead of Wait.


- Mark Michelson


On Jan. 21, 2014, 12:48 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3145/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 12:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds tests for the blind and attended transfer events that are going to be added to ARI.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/bridges/tests.yaml 4574 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/blind_transfer.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3145/diff/
> 
> 
> Testing
> -------
> 
> Ran test, fails using branches. Applied patch for events and it passes!
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/baace3d0/attachment.html>