[asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3102/#review10683
-----------------------------------------------------------



/branches/12/res/res_pjsip_multihomed.c
<https://reviewboard.asterisk.org/r/3102/#comment20174>

    Rewriting the Contact and Via headers makes sense, but rewriting SDP addresses can cause issues:
    
    1) On direct media reinvites, we don't want our local address to be in the SDP.
    
    2) If someone has set a media_address option on the endpoint on which the message is being sent, then do we really want to be overwriting that with our local address?


- Mark Michelson


On Jan. 22, 2014, 3:30 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3102/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 3:30 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23020
>     https://issues.asterisk.org/jira/browse/ASTERISK-23020
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This module adds messaging rewriting for multihomed situations. When messages are sent out it determines what interface and transport the message is going out on. The IP address for this is then placed into the message.
> 
> I've written this as a module since it does add a bit of additional logic for outgoing messages.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_multihomed.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3102/diff/
> 
> 
> Testing
> -------
> 
> Sent and received calls/traffic in two configurations.
> 
> 1. Two transports each bound to specific interfaces
> 2. One transport bound to 0.0.0.0
> 
> Confirmed that the correct IP address for each interface went into the message.
> 
> Some additional testing by others would be nice.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/8d4d1b18/attachment-0001.html>