[asterisk-dev] [Code Review] 3144: Protect manager data structures during shutdown.

[rmudgett]

> On Jan. 21, 2014, 3:18 a.m., Guenther Kelleter wrote:
> > /branches/11/main/manager.c, lines 5628-5633
> > <https://reviewboard.asterisk.org/r/3144/diff/1/?file=52983#file52983line5628>
> >
> >     This replaces session_destroy(...) with unref_mansession(...) so session is not removed from container anymore. Was that intended?

I thought it was an optimization removing duplicate code.  I didn't notice that the code was different.  Oops.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3144/#review10646
-----------------------------------------------------------


On Jan. 20, 2014, 6:04 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3144/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 6:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1242
>     https://issues.asterisk.org/jira/browse/AST-1242
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Occasionally, the manager module would get an "INTERNAL_OBJ: bad magic number" error on a "core restart gracefully" command if an AMI connection is established.
> 
> * Added ao2_global_obj protection to the sessions global container.
> 
> * Fixed the order of unreferencing a session object in session_destroy().
> 
> * Removed unnecessary container traversals of the white/black filters during session_destructor().
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/manager.c 405984 
> 
> Diff: https://reviewboard.asterisk.org/r/3144/diff/
> 
> 
> Testing
> -------
> 
> Since I was not able to reprocuce the INTERNAL_OBJ error reported, I just tested to see that things still worked.
> * The CLI "manager show connected" still works.
> * The system can still restart and shutdown.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140121/266961ce/attachment.html>