[asterisk-dev] [Code Review] 3122: ARI: Add support for specifying channel variables during originate

[opticron]

> On Jan. 17, 2014, 12:38 p.m., Kevin Harwell wrote:
> > branches/12/res/ari/resource_channels.c, lines 753-756
> > <https://reviewboard.asterisk.org/r/3122/diff/2/?file=51449#file51449line753>
> >
> >     I'm sure you looked into this, but is there no way to have this block of code in the auto generated file res_ari_channels.c?  I'm guessing the answer is no as this is probably the crux of the problem, but figured I'd ask :-)

This block of code could easily be in the auto-generated code, but having this behavior be the default would break the model that Swagger operates on and would prevent the body parameter from being used in other ways. A body parameter is ALWAYS expected to consume the entirety of the body's JSON; this one just so happens to parse it as if there were no body parameter and only uses one element in the body.


> On Jan. 17, 2014, 12:38 p.m., Kevin Harwell wrote:
> > branches/12/res/res_ari_channels.c, line 209
> > <https://reviewboard.asterisk.org/r/3122/diff/2/?file=51456#file51456line209>
> >
> >     Is this line auto generated or did you have to manually enter it?  I know the file is and it would be a shame to have to manually edit that file from here on out.

This line lives in res_ari_channels.c and so was auto-generated.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3122/#review10625
-----------------------------------------------------------


On Jan. 13, 2014, 11:09 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3122/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 11:09 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23051
>     https://issues.asterisk.org/jira/browse/ASTERISK-23051
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds back in support for specifying channel variables during an originate without compromising the ability to specify query parameters in the JSON body. This was accomplished by generating the body-parsing code in a separate function instead of being integrated with the URI query parameter parsing code such that it could be called by paths with body parameters. This is transparent to the user of the API and prevents manual duplication of code or data structures.
> 
> 
> Diffs
> -----
> 
>   branches/12/rest-api/api-docs/channels.json 405252 
>   branches/12/rest-api-templates/res_ari_resource.c.mustache 405252 
>   branches/12/rest-api-templates/param_parsing.mustache 405252 
>   branches/12/rest-api-templates/body_parsing.mustache PRE-CREATION 
>   branches/12/rest-api-templates/asterisk_processor.py 405252 
>   branches/12/rest-api-templates/ari_resource.h.mustache 405252 
>   branches/12/res/res_ari_sounds.c 405252 
>   branches/12/res/res_ari_playbacks.c 405252 
>   branches/12/res/res_ari_device_states.c 405252 
>   branches/12/res/res_ari_channels.c 405252 
>   branches/12/res/res_ari_bridges.c 405252 
>   branches/12/res/res_ari_asterisk.c 405252 
>   branches/12/res/res_ari_applications.c 405252 
>   branches/12/res/ari/resource_sounds.h 405252 
>   branches/12/res/ari/resource_playbacks.h 405252 
>   branches/12/res/ari/resource_device_states.h 405252 
>   branches/12/res/ari/resource_channels.c 405252 
>   branches/12/res/ari/resource_channels.h 405252 
>   branches/12/res/ari/resource_bridges.h 405252 
>   branches/12/res/ari/resource_asterisk.h 405252 
>   branches/12/res/ari/resource_applications.h 405252 
> 
> Diff: https://reviewboard.asterisk.org/r/3122/diff/
> 
> 
> Testing
> -------
> 
> Tested with a slightly modified originate_with_vars test created for the original functionality by Kevin Harwell.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140117/f8182264/attachment.html>