[asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/#review10619
-----------------------------------------------------------


Without going into the functionality of the patch, a few notes:


asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
<https://reviewboard.asterisk.org/r/3051/#comment20117>

    You're referencing more than the ";tag" bit, below:
    
    To: [$remote_tag]



asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
<https://reviewboard.asterisk.org/r/3051/#comment20118>

    I think you can do:
    
    From: [last_To]
    To: [last_From]
    
    But don't take my word for it.



asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
<https://reviewboard.asterisk.org/r/3051/#comment20119>

    A bit inconsitent with contacts with and without angle brackets. Not that it matters.


- wdoekes


On Jan. 6, 2014, 9:53 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3051/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 9:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21084
>     https://issues.asterisk.org/jira/browse/ASTERISK-21084
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds a test which covers path support for outbound registrations, inbound registrations, and outbound requests following an inbound registration.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 4485 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3051/diff/
> 
> 
> Testing
> -------
> 
> Ensured the tests behaved as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140117/29bd7561/attachment.html>