[asterisk-dev] [Code Review] 3129: chan_pjsip: Provide a means for updating device state when going on/off hold

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3129/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 2:56 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Address feedback


Repository: Asterisk


Description
-------

Maintains a list of on hold channel uniqueids.  When a snapshot is used with chan_pjsip's device state evaluating function, this list is queried to see if the channel in the snapshot is on hold. As the channel receives indications of HOLD/UNHOLD, this list is updated and the device state is updated. When the session ends, the session channel is removed from the list if it is still in it.


Diffs (updated)
-----

  /branches/12/channels/chan_pjsip.c 405641 

Diff: https://reviewboard.asterisk.org/r/3129/diff/


Testing
-------

Manual testing where I watched the device state with a websocket, polled for device state with Manager command GetVar and DEVICE_STATE function, and also modified an automated test (channels/pjsip/hold) to have a hint which checks the device state of a PJSIP channel and ExtensionStatus event is monitored to evaluate device state changes as they had.

The test modifications will be in another review.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140116/ec5debbc/attachment.html>