[asterisk-dev] [Code Review] 3043: pjsip: CLI commands

George Joseph reviewboard at asterisk.org
Thu Jan 16 07:46:35 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3043/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 1:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Bugs: ASTERISK-22610
    https://issues.asterisk.org/jira/browse/ASTERISK-22610


Repository: Asterisk


Description
-------

Implements the following cli commands:
pjsip list aors
pjsip list auths
pjsip list channels
pjsip list contacts
pjsip list endpoints
pjsip show aor(s)
pjsip show auth(s)
pjsip show channels
pjsip show endpoint(s)

Also...
Minor modifications made to the AMI command implementations to facilitate reuse.
New function ast_variable_list_sort added to config.c and config.h to implement variable list sorting.
New api ast_sip_for_each_identify added to module res_pjsip_endpoint_identifier_ip. Required new files res_pjsip_endpoint_identifier_ip.h and res_pjsip_endpoint_identifier_ip.exports.in.

Implementation of the summary statistics is still pending.
I'm sure there will be lots of feedback here. :)


Diffs
-----

  branches/12/res/res_pjsip_registrar.c 404396 
  branches/12/res/res_pjsip_endpoint_identifier_ip.exports.in PRE-CREATION 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 404396 
  branches/12/res/res_pjsip/pjsip_configuration.c 404396 
  branches/12/res/res_pjsip/pjsip_cli.c PRE-CREATION 
  branches/12/res/res_pjsip/location.c 404396 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 404396 
  branches/12/res/res_pjsip/config_auth.c 404396 
  branches/12/main/sorcery.c 404396 
  branches/12/main/config.c 404396 
  branches/12/include/asterisk/sorcery.h 404396 
  branches/12/include/asterisk/res_pjsip_endpoint_identifier_ip.h PRE-CREATION 
  branches/12/include/asterisk/res_pjsip_cli.h PRE-CREATION 
  branches/12/include/asterisk/res_pjsip.h 404396 
  branches/12/include/asterisk/config.h 404396 

Diff: https://reviewboard.asterisk.org/r/3043/diff/


Testing
-------

I've gone through all the combinations of actions and objects and made sure at least the correct objects are returned, there are no segfaults, errors, etc.
I *think* the formatting is correct but I'll need some feedback.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140116/b0ce6c33/attachment.html>


More information about the asterisk-dev mailing list