[asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3093/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 2:35 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-21443
    https://issues.asterisk.org/jira/browse/ASTERISK-21443


Repository: Asterisk


Description
-------

Some devices use the dialog-info+xml to get presence information about an extension. The attached change implements this but DOES NOT implement the "pickup ringing channel" functionality available on Snoms.

To facilitate this implementation I have also changed it so the subscription is passed to the body creation callback. This allows implementations to store state information on the subscription.


Diffs (updated)
-----

  /branches/12/res/res_pjsip_pidf.c 405576 
  /branches/12/res/res_pjsip_exten_state.c 405576 
  /branches/12/res/res_pjsip_dialog_info.c PRE-CREATION 
  /branches/12/include/asterisk/res_pjsip_exten_state.h 405576 
  /branches/12/UPGRADE.txt 405576 

Diff: https://reviewboard.asterisk.org/r/3093/diff/


Testing
-------

Subscribed to an extension from a device that uses dialog-info+xml. Confirmed NOTIFY messages going out contain the expected content.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140115/2512ff3b/attachment.html>