[asterisk-dev] [Code Review] 3096: PEP 8-ify the Asterisk Testsuite python libraries

wdoekes reviewboard at asterisk.org
Mon Jan 13 12:39:03 CST 2014 


> On Jan. 9, 2014, 9:55 p.m., Kevin Harwell wrote:
> > /asterisk/trunk/lib/python/asterisk/BridgeTestCase.py, line 229
> > <https://reviewboard.asterisk.org/r/3096/diff/1/?file=50801#file50801line229>
> >
> >     More a question of curisiosity here, but is there a reason a return value was added?  It doesn't appear to be used.
> >     
> >     (was added in a few other methods too)
> 
> Matt Jordan wrote:
>     Mostly just added because it gets rid of the Pylint "parameter not used" error.
>     
>     In the end, there's two pseudo-useful reasons to have it here beyond that:
>     (1) If, for whatever reason, starpy was modified to actually call the event callbacks in a deferred, then each AMI event callback would be returning something to pass to the next callback, which is generally nice
>     (2) It doesn't hurt anything?
>     
>     But really, I wouldn't care if someone didn't bother with this, or we removed them.

Just touching them should get rid of the error too.

Putting this at the top is better than adding useless/undefined return values:

    (ami, event)  # touched for pylint


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3096/#review10539
-----------------------------------------------------------


On Dec. 30, 2013, 9:52 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3096/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 9:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch does a reasonable job of making the Python code in lib/python/asterisk compliant with PEP 8. (Reasonable being > 9 on the pylint "how am I doing?" code rating)
> 
> A few disclaimers:
> (1) This patch does not go into the python code for the tests themselves, other than to make the tests run. Making the individual tests PEP 8 compliant would be nice, but it's a whole lot more work with less benefit.
> (2) Not *everything* was cleaned up in the libraries. In general, I tried to get the vast majority of findings, but there are a few minor nitpicks here and there.
> (3) This patch is scarier than it looks. No semantics were changed in the process of doing this: this is all just formatting/guidelines/etc.
> 
> Note that this will break the world, however, as it renames a number of python modules, functions, etc.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/udptl_v6/run-test 4535 
>   /asterisk/trunk/tests/udptl/run-test 4535 
>   /asterisk/trunk/tests/skeleton_test/run-test UNKNOWN 
>   /asterisk/trunk/tests/rest_api/request-bodies/run-test 4535 
>   /asterisk/trunk/tests/rest_api/content-type/run-test 4535 
>   /asterisk/trunk/tests/rest_api/authentication/run-test 4535 
>   /asterisk/trunk/tests/rest_api/CORS/run-test 4535 
>   /asterisk/trunk/tests/regressions/M18882/run-test 4535 
>   /asterisk/trunk/tests/predial/run-test 4535 
>   /asterisk/trunk/tests/pbx/pbx_lua_goto/run-test 4535 
>   /asterisk/trunk/tests/pbx/pbx_lua_background/run-test 4535 
>   /asterisk/trunk/tests/pbx/merge_contexts/run-test 4535 
>   /asterisk/trunk/tests/pbx/dialplan_reload/run-test 4535 
>   /asterisk/trunk/tests/pbx/dialplan/test-config.yaml 4535 
>   /asterisk/trunk/tests/pbx/callerid_match/run-test 4535 
>   /asterisk/trunk/tests/pbx/call-files/run-test 4535 
>   /asterisk/trunk/tests/masquerade/run-test 4535 
>   /asterisk/trunk/tests/manager/login/run-test 4535 
>   /asterisk/trunk/tests/manager/danger/safe/run-test 4535 
>   /asterisk/trunk/tests/manager/danger/dangerous/run-test 4535 
>   /asterisk/trunk/tests/manager/bridge_actions/test-config.yaml 4535 
>   /asterisk/trunk/tests/manager/acl-login/run-test 4535 
>   /asterisk/trunk/tests/hangup/handlers_endbeforehexten/run-test 4535 
>   /asterisk/trunk/tests/hangup/handlers/run-test 4535 
>   /asterisk/trunk/tests/funcs/func_srv/run-test 4535 
>   /asterisk/trunk/tests/funcs/func_presencestate/run-test 4535 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/run-test 4535 
>   /asterisk/trunk/tests/funcs/func_global/test-config.yaml 4535 
>   /asterisk/trunk/tests/feature_call_pickup/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/voxfax_g711/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/local_channel_t38_queryoption/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_timeout5/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_timeout4/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_timeout3/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_timeout2/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_timeout1/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_t38_g711/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_no_t38/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_native_t38_ced/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_native_t38/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_mix4/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_mix3/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_mix2/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_mix1/run-test 4535 
>   /asterisk/trunk/tests/fax/sip/gateway_g711_t38/run-test 4535 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/run-test 4535 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/run-test 4535 
>   /asterisk/trunk/tests/fastagi/stream-file/run-test 4535 
>   /asterisk/trunk/tests/fastagi/database/run-test 4535 
>   /asterisk/trunk/tests/fastagi/control-stream-file/run-test 4535 
>   /asterisk/trunk/tests/fastagi/connect/run-test 4535 
>   /asterisk/trunk/tests/fastagi/channel-status/run-test 4535 
>   /asterisk/trunk/tests/dynamic-modules/run-test 4535 
>   /asterisk/trunk/tests/channels/pjsip/message/message_send_ami/run-test 4535 
>   /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_endpoint/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_incompatible_codecs/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/playback/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/echo/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/AMISendTest.py 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/AMISendTest.py 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/AMISendTest.py 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/AMISendTest.py 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/AMISendTest.py 4535 
>   /asterisk/trunk/tests/channels/local/local_optimize_away/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/local/local_holding_bridge/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/local/local_call/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/local/local_app/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/iax2/hangupcause/run-test 4535 
>   /asterisk/trunk/tests/channels/iax2/basic-call/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/iax2/acl_call/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/use_contact_from_200/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_srtp/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_hold/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_custom_presence/resubscribe/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_custom_presence/non_digium_state_change/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_custom_presence/nominal_state_change/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_custom_presence/multiple_state_change/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_cause/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_blind_transfer/caller_refer_only/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_blind_transfer/callee_refer_only/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_attended_transfer_tcp/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip_attended_transfer/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/sip2cause/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uac_se_below_minse/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/SIP/session_timers/basic_uac_teardown/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/SIP/session_timers/basic_uac_refresh/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/SIP/secure_bridge_media/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/pcap_demo/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/path/test-config.yaml 4535 
>   /asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/noload_res_srtp/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/nat_supertest/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/message_send_ami/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/info_dtmf/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/hangupcause/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/generic_ccss/run-test 4535 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/run-test 4535 
>   /asterisk/trunk/tests/cdr/console_dial_sip_transfer/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_unanswered_yes/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_properties/cdr_userfield/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_properties/cdr_accountcode/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_originate_sip_congestion_log/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_manipulation/nocdr/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_before_dial/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_after_busy_forward/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr_manipulation/cdr_fork_end_time/test-config.yaml 4535 
>   /asterisk/trunk/tests/cdr/cdr-tests.py 4535 
>   /asterisk/trunk/tests/cdr/batch_cdrs/test-config.yaml 4535 
>   /asterisk/trunk/tests/cause_answered_elsewhere/run-test 4535 
>   /asterisk/trunk/tests/callparking_retrieval/run-test 4535 
>   /asterisk/trunk/tests/callparking/run-test 4535 
>   /asterisk/trunk/tests/bridge/transfer_failure/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/transfer_capabilities_bridgefeatures/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/transfer_capabilities/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/simple_bridge/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/parkcall_bridgefeatures/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/parkcall/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/disconnect/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/dial_LS_options/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/connected_line_update/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/bridge_action/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/bridge_action/bridge_action.py 4535 
>   /asterisk/trunk/tests/bridge/blonde_nominal/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/blindxfer_setup/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/blindxfer_nominal/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/automon_bridgefeatures/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/automon/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/automixmon_bridgefeatures/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/automixmon/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/atxfer_threeway_nominal/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/atxfer_setup/test-config.yaml 4535 
>   /asterisk/trunk/tests/bridge/atxfer_nominal/test-config.yaml 4535 
>   /asterisk/trunk/tests/asyncagi/asyncagi_break/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/voicemail/play_message/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/func_vmcount/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/run-test 4535 
>   /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/run-test 4535 
>   /asterisk/trunk/tests/apps/queues/set_penalty/run-test 4535 
>   /asterisk/trunk/tests/apps/queues/reload_queue_members/run-test 4535 
>   /asterisk/trunk/tests/apps/queues/queue_transfer_callee/run-test UNKNOWN 
>   /asterisk/trunk/tests/apps/queues/queue_penalty_outside_range/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/queues/queue_one_paused_no_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/queues/queue_no_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/queues/queue_baseline/run-test 4535 
>   /asterisk/trunk/tests/apps/queues/queue_all_paused_no_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test 4535 
>   /asterisk/trunk/tests/apps/playback/nominal/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/page/page_baseline/run-test 4535 
>   /asterisk/trunk/tests/apps/mixmonitor_func/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test 4535 
>   /asterisk/trunk/tests/apps/mixmonitor/testaudio2.raw UNKNOWN 
>   /asterisk/trunk/tests/apps/mixmonitor/testaudio1.raw UNKNOWN 
>   /asterisk/trunk/tests/apps/incomplete/sip_incomplete/run-test 4535 
>   /asterisk/trunk/tests/apps/directory/directory_operator_exit/run-test 4535 
>   /asterisk/trunk/tests/apps/directory/directory_context_operator_exit/run-test 4535 
>   /asterisk/trunk/tests/apps/directory/directory_attendant_exit/run-test 4535 
>   /asterisk/trunk/tests/apps/directed_pickup/run-test 4535 
>   /asterisk/trunk/tests/apps/dial/dial_unavail/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_timeout/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_unavail/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_congestion/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_busy/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_unavail/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_congestion/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_cancel/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_busy/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_no_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_hangup/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_dtmf_hangup_cancel/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_congestion/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_busy/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/dial/dial_answer/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/control_playback/nominal/test-config.yaml 4535 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/run-test 4535 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/run-test 4535 
>   /asterisk/trunk/tests/apps/chanspy/chanspy_w_mixmonitor/run-test 4535 
>   /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test 4535 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml 4535 
>   /asterisk/trunk/test-config.yaml 4535 
>   /asterisk/trunk/runtests.py 4535 
>   /asterisk/trunk/logger.conf 4535 
>   /asterisk/trunk/lib/python/asterisk/voicemail.py 4535 
>   /asterisk/trunk/lib/python/asterisk/version.py 4535 
>   /asterisk/trunk/lib/python/asterisk/syncami.py 4535 
>   /asterisk/trunk/lib/python/asterisk/sippversion.py 4535 
>   /asterisk/trunk/lib/python/asterisk/sipp.py 4535 
>   /asterisk/trunk/lib/python/asterisk/config.py 4535 
>   /asterisk/trunk/lib/python/asterisk/confbridge.py 4535 
>   /asterisk/trunk/lib/python/asterisk/cel.py 4535 
>   /asterisk/trunk/lib/python/asterisk/cdr.py 4535 
>   /asterisk/trunk/lib/python/asterisk/buildoptions.py 4535 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 4535 
>   /asterisk/trunk/lib/python/asterisk/astcsv.py 4535 
>   /asterisk/trunk/lib/python/asterisk/ari.py 4535 
>   /asterisk/trunk/lib/python/asterisk/apptest.py 4535 
>   /asterisk/trunk/lib/python/asterisk/ami.py 4535 
>   /asterisk/trunk/lib/python/asterisk/ThreadTestCondition.py 4535 
>   /asterisk/trunk/lib/python/asterisk/ThreadTestCondition.py 4509 
>   /asterisk/trunk/lib/python/asterisk/TestSuiteUtils.py 4535 
>   /asterisk/trunk/lib/python/asterisk/TestSuiteUtils.py 4509 
>   /asterisk/trunk/lib/python/asterisk/TestState.py 4535 
>   /asterisk/trunk/lib/python/asterisk/TestState.py 4509 
>   /asterisk/trunk/lib/python/asterisk/TestRunner.py 4535 
>   /asterisk/trunk/lib/python/asterisk/TestRunner.py 4509 
>   /asterisk/trunk/lib/python/asterisk/TestConfig.py 4509 
>   /asterisk/trunk/lib/python/asterisk/TestConfig.py 4535 
>   /asterisk/trunk/lib/python/asterisk/TestConditions.py 4509 
>   /asterisk/trunk/lib/python/asterisk/TestConditions.py 4535 
>   /asterisk/trunk/lib/python/asterisk/TestCase.py 4509 
>   /asterisk/trunk/lib/python/asterisk/TestCase.py 4535 
>   /asterisk/trunk/lib/python/asterisk/SipDialogTestCondition.py 4535 
>   /asterisk/trunk/lib/python/asterisk/SipDialogTestCondition.py 4509 
>   /asterisk/trunk/lib/python/asterisk/SipChannelTestCondition.py 4535 
>   /asterisk/trunk/lib/python/asterisk/SipChannelTestCondition.py 4509 
>   /asterisk/trunk/lib/python/asterisk/SimpleTestCase.py 4535 
>   /asterisk/trunk/lib/python/asterisk/PluggableModules.py 4535 
>   /asterisk/trunk/lib/python/asterisk/PluggableModules.py 4509 
>   /asterisk/trunk/lib/python/asterisk/LockTestCondition.py 4535 
>   /asterisk/trunk/lib/python/asterisk/LockTestCondition.py 4509 
>   /asterisk/trunk/lib/python/asterisk/FdTestCondition.py 4535 
>   /asterisk/trunk/lib/python/asterisk/FdTestCondition.py 4509 
>   /asterisk/trunk/lib/python/asterisk/ChannelTestCondition.py 4535 
>   /asterisk/trunk/lib/python/asterisk/ChannelTestCondition.py 4509 
>   /asterisk/trunk/lib/python/asterisk/CDRTestCase.py 4535 
>   /asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 4535 
>   /asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 4509 
> 
> Diff: https://reviewboard.asterisk.org/r/3096/diff/
> 
> 
> Testing
> -------
> 
> Everything still runs.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140113/14442a4a/attachment-0001.html>

More information about the asterisk-dev mailing list