[asterisk-dev] [Code Review] 3114: verbosity: Fix performance of console verbose messages.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3114/#review10550
-----------------------------------------------------------



/branches/11/main/cli.c
<https://reviewboard.asterisk.org/r/3114/#comment20004>

    I'd get rid of still. I'm not sure why you need it here - it looks like you can just use "%s is still %d" and "%s is still OFF"



/branches/11/main/logger.c
<https://reviewboard.asterisk.org/r/3114/#comment20003>

    Why an int *?



/branches/11/main/logger.c
<https://reviewboard.asterisk.org/r/3114/#comment20002>

    Use sizeof(*console). Per coding guidelines:
    
    "Using sizeof(*tmp) instead of sizeof(struct foo) eliminates duplication of the 'struct foo' identifier, which makes the code easier to read and also ensures that if it is copy-and-pasted it won't require as much editing."
    
    Plus it makes this look like the rest of our code, which is nice.


- Matt Jordan


On Jan. 9, 2014, 1:30 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3114/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 1:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1252
>     https://issues.asterisk.org/jira/browse/AST-1252
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The per console verbose level feature as previously implemented caused a large performance penalty.  The fix required some minor incompatibilities if the new rasterisk is used to connect to an earlier version.  If the new rasterisk connects to an older Asterisk version then the root console verbose level is always affected by the "core set verbose" command of the remote console even though it may appear to only affect the current console.  If an older version of rasterisk connects to the new version then the "core set verbose" command will have no effect.
> 
> * Fixed the verbose performance by not generating a verbose message if nothing is going to use it and then filtered any generated verbose messages before actually sending them to the remote consoles.
> 
> * Split the "core set debug" and "core set verbose" CLI commands to remove the per module verbose support that cannot work with the per console verbose level.
> 
> * Added a silent option to the "core set verbose" command.
> 
> * Fixed "core set debug off" tab completion.
> 
> * Made "core show settings" list the current console verbosity in addition to the root console verbosity.
> 
> * Changed the default verbose level of the 'verbose' setting in the logger.conf [logfiles] section.  The default is now to once again follow the current root console level.  As a result, using the AMI Command action with "core set verbose" could again set the root console verbose level and affect the verbose level logged.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/pbx.c 405252 
>   /branches/11/main/manager.c 405252 
>   /branches/11/main/logger.c 405252 
>   /branches/11/main/cli.c 405252 
>   /branches/11/main/asterisk.c 405252 
>   /branches/11/include/asterisk/logger.h 405252 
>   /branches/11/funcs/func_timeout.c 405252 
>   /branches/11/configs/logger.conf.sample 405252 
>   /branches/11/UPGRADE.txt 405252 
> 
> Diff: https://reviewboard.asterisk.org/r/3114/diff/
> 
> 
> Testing
> -------
> 
> Setup an extension that had a simple dialplan extension that decremented a counter from 500000 and nothing logging or viewing verbose messages.
> On my machine, Asterisk v11 without the patch took 63 seconds while with the patch it took 25 seconds.
> 
> Tested the "core set verbose" CLI command tab completion.
> 
> Tested that different verbose levels on multiple rasterisk connections got the expected verbose messages.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/4623588a/attachment-0001.html>