[asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

Olle E Johansson reviewboard at asterisk.org
Thu Jan 9 13:57:19 CST 2014



> On Jan. 7, 2014, 10:29 a.m., Olle E Johansson wrote:
> > Please also check the sender IP address in the IP packet. That's where things go wrong with chan_sip. Thanks.
> 
> Matt Jordan wrote:
>     Olle - just so I understand your comment, are you referring to what would happen if the sender was behind a NAT?

No, but it will happen in many scenarios when you bind to 0.0.0.0 in chan_sip and have multiple IPs and interfaces on your system. We put the right address in the SIP message, but send from the wrong IP.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3102/#review10519
-----------------------------------------------------------


On Jan. 6, 2014, 9:06 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3102/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 9:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23020
>     https://issues.asterisk.org/jira/browse/ASTERISK-23020
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This module adds messaging rewriting for multihomed situations. When messages are sent out it determines what interface and transport the message is going out on. The IP address for this is then placed into the message.
> 
> I've written this as a module since it does add a bit of additional logic for outgoing messages.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_multihomed.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3102/diff/
> 
> 
> Testing
> -------
> 
> Sent and received calls/traffic in two configurations.
> 
> 1. Two transports each bound to specific interfaces
> 2. One transport bound to 0.0.0.0
> 
> Confirmed that the correct IP address for each interface went into the message.
> 
> Some additional testing by others would be nice.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/e24a2f27/attachment.html>


More information about the asterisk-dev mailing list