[asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3050/
-----------------------------------------------------------

(Updated Jan. 9, 2014, 11:33 a.m.)


Review request for Asterisk Developers.


Changes
-------

Address Joshua's comments.


Bugs: ASTERISK-21084
    https://issues.asterisk.org/jira/browse/ASTERISK-21084


Repository: Asterisk


Description
-------

This adds Path support to chan_pjsip in res_pjsip_path.c with minimal additions in res_pjsip_registrar.c to store the path and additions in res_pjsip_outbound_registration.c to enable advertisement of path support to registrars and intervening proxies.

Path information is stored on contacts and is enabled via Address of Record (AoRs) and Registration configuration sections.

While adding path support, it became necessary to be able to add SIP supplements that handled messages outside of sessions, so a framework for handling these types of hooks was added in parallel to the already-existing session supplements and several senders of out-of-dialog requests were refactored as a result.


Diffs (updated)
-----

  /trunk/res/res_pjsip_t38.c 405249 
  /trunk/res/res_pjsip_session.c 405249 
  /trunk/res/res_pjsip_registrar.c 405249 
  /trunk/res/res_pjsip_refer.c 405249 
  /trunk/res/res_pjsip_path.c PRE-CREATION 
  /trunk/res/res_pjsip_outbound_registration.c 405249 
  /trunk/res/res_pjsip_notify.c 405249 
  /trunk/res/res_pjsip_nat.c 405249 
  /trunk/res/res_pjsip_mwi.c 405249 
  /trunk/res/res_pjsip_messaging.c 405249 
  /trunk/res/res_pjsip_header_funcs.c 405249 
  /trunk/res/res_pjsip_diversion.c 405249 
  /trunk/res/res_pjsip_caller_id.c 405249 
  /trunk/res/res_pjsip/pjsip_options.c 405249 
  /trunk/res/res_pjsip/pjsip_distributor.c 405249 
  /trunk/res/res_pjsip/location.c 405249 
  /trunk/res/res_pjsip.c 405249 
  /trunk/include/asterisk/res_pjsip_session.h 405249 
  /trunk/include/asterisk/res_pjsip.h 405249 
  /trunk/channels/chan_pjsip.c 405249 

Diff: https://reviewboard.asterisk.org/r/3050/diff/


Testing
-------

This passes the tests covered by the review at https://reviewboard.asterisk.org/r/3051/

These tests were converted to work with chan_pjsip from their chan_sip counterparts.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/0d86cb0b/attachment-0001.html>