[asterisk-dev] [Code Review] 3094: res_pjsip_messaging: potential for field values in from/to headers to be missing

Kevin Harwell reviewboard at asterisk.org
Mon Jan 6 12:49:45 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3094/
-----------------------------------------------------------

(Updated Jan. 6, 2014, 12:49 p.m.)


Review request for Asterisk Developers.


Changes
-------

Changed formatting, when possible, of uri on incoming messages to remove redundent 'pjsip:<sip:' in tech.  This should now read 'pjsip:' only.


Bugs: ASTERISK-22924
    https://issues.asterisk.org/jira/browse/ASTERISK-22924


Repository: Asterisk


Description
-------

Added in ability to specify display name format ("name" <sip:name at ipaddr:port>) for a given URI and made sure it was fully propagated to the outgoing message.  This mainly occurred when sending to a direct URI (using the default outbound endpoint).  MESSAGEs sent to/from a valid endpoint will use that endpoint's AOR/contact to fill in the appropriate information.


Diffs (updated)
-----

  branches/12/res/res_pjsip_messaging.c 404949 
  branches/12/res/res_pjsip.c 404949 

Diff: https://reviewboard.asterisk.org/r/3094/diff/


Testing
-------

Some manual testing and also ran the current testsuite tests that exists to make sure everything still worked as expected.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140106/d1c3d3a6/attachment.html>


More information about the asterisk-dev mailing list