[asterisk-dev] [Code Review] 3098: compiler warnings

Kevin Harwell reviewboard at asterisk.org
Thu Jan 2 12:51:44 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3098/
-----------------------------------------------------------

(Updated Jan. 2, 2014, 12:51 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Modified code in chan_unistim to use unsigned int.  Not really sure why that fixed the issue (seems like a gcc compiler problem maybe), but it did.


Repository: Asterisk


Description
-------

Fixed a couple of compiler warnings (errors in 'dev-mode') given by gcc version 4.8.1 (on Ubuntu).  The one in app_meetme involved the 'sizeof-pointer-memaccess' (see: http://gcc.gnu.org/gcc-4.8/porting_to.html) warning.  The one in chan_unistim was issuing an array out of bounds message.  Fixed both so they would no longer issue warnings and can compile again in 'dev-mode'.


Diffs (updated)
-----

  branches/1.8/channels/chan_unistim.c 404591 
  branches/1.8/apps/app_meetme.c 404591 

Diff: https://reviewboard.asterisk.org/r/3098/diff/


Testing
-------


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140102/0a944ffd/attachment.html>


More information about the asterisk-dev mailing list