[asterisk-dev] [Code Review] 3265: media_formats: Move app_fax over

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3265/#review10987
-----------------------------------------------------------



/team/file/media_formats-impl/apps/app_fax.c
<https://reviewboard.asterisk.org/r/3265/#comment20628>

    What happens if orginal_read/write_fmt(s) are NULL?  Still proceed with setting the format even though it won't be restored later?  Not a problem if it was slin before.


- Kevin Harwell


On Feb. 25, 2014, 6:55 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3265/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 6:55 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves app_fax over to the new media formats API.
> 
> 
> Diffs
> -----
> 
>   /team/file/media_formats-impl/apps/app_fax.c 408263 
> 
> Diff: https://reviewboard.asterisk.org/r/3265/diff/
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/f31957bb/attachment.html>